193 lines
8.9 KiB
Markdown
193 lines
8.9 KiB
Markdown
---
|
|
judul: Bug Report — Submit registrasi customer gagal 500 karena role Customer di-rename jadi Dealer
|
|
proyek: SFA CMS · SFA API
|
|
terkait: Mito
|
|
server: VPS MITO dev `/var/www/sfa_mito` + `/var/www/sfa_api_mito` (16.79.56.41)
|
|
kategori: Bug
|
|
status: Solved — sfa-api 19fba4d, sfa-cms 940e492
|
|
tipe: dokumen-internal
|
|
tags:
|
|
- sfa
|
|
- cms
|
|
- api
|
|
- bug
|
|
- registration
|
|
- role
|
|
diperbarui: 2026-10-20
|
|
---
|
|
|
|
> Index: [[SFA — Index]] · Kategori: **Bug** · Fitur: [[SFA — Self Registration]] · [[SFA API — Login Terpadu auth-login]]
|
|
|
|
# Bug Report: Submit registrasi customer gagal 500 — role `Customer` di-rename jadi `Dealer`
|
|
**Tanggal:** 20 Oktober 2026
|
|
**Server/Environment:** VPS MITO — server **develop** (`ip-172-31-21-236`): SFA CMS `/var/www/sfa_mito` (Jenkins), SFA API `/var/www/sfa_api_mito` (pm2 `sfa-api-dev`, port 3069), MySQL `sfa_mito` (dipakai bersama)
|
|
**Project:** SFA API (`MITO/sfa-api`) · SFA CMS (`MITO/sfa-cms`)
|
|
**Status:** ✅ Solved
|
|
|
|
---
|
|
|
|
## Ringkasan Masalah
|
|
|
|
Tes `POST /registration/submit` lewat Swagger server dev awalnya ditolak 400 karena `attachment` dikirim
|
|
`[]` (aturannya memang wajib minimal 1 dokumen). Setelah diisi satu dokumen base64 yang valid, request
|
|
gagal **500** `Role Customer belum ada`, padahal migration CMS pembuat role sudah tercatat `Ran`.
|
|
|
|
Ternyata role `Customer` (id 6) tidak hilang, tapi **di-rename jadi `Dealer`** lewat menu CMS → Shield →
|
|
Roles. Node API mencari role berdasarkan **nama** (`name = 'Customer' AND guard_name = 'web'`), jadi
|
|
tidak ketemu. Diputuskan `Dealer` jadi nama resmi: Node disesuaikan, dan migration CMS baru menyamakan
|
|
nama role di semua server (termasuk 5 server production yang masih akan dapat `Customer` dari migration lama).
|
|
|
|
---
|
|
|
|
## Alur Penyebab & Fix
|
|
|
|
```mermaid
|
|
flowchart TD
|
|
A["POST /registration/submit"] --> B{"attachment ≥ 1?"}
|
|
B -- "tidak, []" --> E1["400 arrayMin<br/>attachment must contain at least 1 items"]
|
|
B -- "ya" --> C["checkDuplicate → matchCustomer<br/>→ createRegistrantUser"]
|
|
C --> D{"roles WHERE name = ROLE_CUSTOMER<br/>AND guard_name = 'web'"}
|
|
D -- "cari 'Customer' (sebelum fix)" --> E2["500 Role Customer belum ada.<br/>Jalankan migration CMS terlebih dahulu."]
|
|
D -- "cari 'Dealer' (19fba4d)" --> OK["201 registrasi SUBMITTED<br/>role Dealer (id 6) dipasang"]
|
|
R["Migration 2026_10_08_000001<br/>buat role 'Customer' (id 6)"] -. "2026-10-13 06:26<br/>rename lewat Shield → Roles" .-> R2["role id 6 = 'Dealer'"]
|
|
R2 --> D
|
|
M["Migration 2026_10_20_000003<br/>(940e492)"] -. "server lain:<br/>Customer → Dealer" .-> R2
|
|
P["Kunci role sistem di UI Shield<br/>(belum dikerjakan)"]
|
|
|
|
classDef ok fill:#d1fae5,stroke:#059669,color:#064e3b
|
|
classDef err fill:#fee2e2,stroke:#dc2626,color:#7f1d1d
|
|
classDef todo fill:#f3f4f6,stroke:#9ca3af,color:#374151,stroke-dasharray:4 3
|
|
class OK,M ok
|
|
class E1,E2 err
|
|
class P todo
|
|
```
|
|
|
|
Hijau = sukses / fix · Merah = ditolak / gagal · Abu-abu putus-putus = belum dikerjakan
|
|
|
|
---
|
|
|
|
## Timeline & Error
|
|
|
|
### Error 1: `arrayMin` — attachment kosong
|
|
```
|
|
{
|
|
"status": "failed",
|
|
"msg": [
|
|
{
|
|
"type": "arrayMin",
|
|
"message": "The 'attachment' field must contain at least 1 items.",
|
|
"field": "attachment",
|
|
"expected": 1,
|
|
"actual": 0
|
|
}
|
|
]
|
|
}
|
|
```
|
|
**Penyebab:** di `routes/validator/validatorRegistration.js` aturan `attachment` untuk submit registrasi
|
|
customer adalah `min: 1, max: 5`. Payload uji juga sempat dikira untuk registrasi staff, padahal staff pakai
|
|
endpoint lain (`POST /registration/staff/submit`, token dealer, attachment opsional).
|
|
**Fix:** kirim satu dokumen dengan format data URI `data:<mime>;base64,<isi>`:
|
|
```json
|
|
"attachment": [
|
|
{
|
|
"doc_type": "KTP",
|
|
"file": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAADElEQVR4nGP4//8/AAX+Av4N70a4AAAAAElFTkSuQmCC"
|
|
}
|
|
]
|
|
```
|
|
> Perubahan lokal yang membuat `attachment` opsional (validator, `attachment = []` di service, swagger)
|
|
> **belum di-commit**, karena keputusan wajib/opsional dokumen belum final.
|
|
|
|
### Error 2: `Role Customer belum ada`
|
|
```
|
|
{
|
|
"status": "error",
|
|
"message": "Role Customer belum ada. Jalankan migration CMS terlebih dahulu."
|
|
}
|
|
```
|
|
**Penyebab:** `assignCustomerRole` di `routes/services/serviceRegistration.js` menjalankan
|
|
`SELECT id FROM roles WHERE name = :name AND guard_name = :guard`, dengan `ROLE_CUSTOMER = "Customer"`.
|
|
|
|
Investigasi di server:
|
|
```bash
|
|
php artisan migrate:status | tail -15
|
|
# 2026_10_08_000001_add_status_to_users_and_customer_role ... [9] Ran
|
|
grep -E '^DB_(HOST|DATABASE)=' /var/www/sfa_mito/.env # DB_DATABASE=sfa_mito
|
|
grep -E "^(DB_HOSTNAME|DB_NAME)=" /var/www/sfa_api_mito/.env # DB_NAME=sfa_mito → DB sama
|
|
```
|
|
Isi `roles` (DB `sfa_mito`):
|
|
|
|
| id | name | user_type | created_at | updated_at | user |
|
|
|---|---|---|---|---|---|
|
|
| 6 | **Dealer** | EXTERNAL | 2026-10-08 06:46:42 | **2026-10-13 06:26:01** | 11 |
|
|
| 7 | Dealer Staff | EXTERNAL | 2026-10-13 03:42:57 | 2026-10-13 03:42:57 | 6 |
|
|
|
|
`created_at` id 6 = waktu migration `2026_10_08_000001` jalan, `updated_at` = waktu rename lewat UI.
|
|
Ke-11 user pemegang id 6 **semuanya** registrant (`customer_registration.user_id`, 11/11). Di kode CMS tidak
|
|
ada yang bergantung pada nama role `Customer`, hanya Node.
|
|
|
|
**Fix:**
|
|
1. **sfa-api `19fba4d`**: `routes/helpers/enums/registrationStatus.js` → `ROLE_CUSTOMER = "Dealer"`.
|
|
2. **sfa-cms `940e492`**: migration `2026_10_20_000003_rename_customer_role_to_dealer.php`, idempotent:
|
|
- hanya ada `Customer` → rename jadi `Dealer`
|
|
- ada `Customer` dan `Dealer` → user dipindah ke `Dealer` (lewati yang sudah punya), `Customer` dihapus
|
|
- hanya ada `Dealer` → tidak berubah (kondisi server dev)
|
|
- keduanya tidak ada → buat `Dealer`
|
|
- set `user_type = EXTERNAL`, `forgetCachedPermissions()`
|
|
|
|
### Error 3: server Node tidak bisa pull
|
|
```
|
|
fatal: could not read Username for 'https://repo.sinerka.id': No such device or address
|
|
```
|
|
**Penyebab:** remote `/var/www/sfa_api_mito` memakai HTTPS (`https://repo.sinerka.id/MITO/sfa-api.git`)
|
|
tanpa kredensial. Server tidak punya deploy key untuk sfa-api, berbeda dengan CMS (`~ubuntu/.ssh/sfa_cms_deploy`).
|
|
CMS ter-deploy otomatis oleh Jenkins (migration `[19] Ran`); Node tidak.
|
|
**Fix:** kirim commit lewat `git bundle` lalu fast-forward ke commit yang sama persis dengan `origin/develop`
|
|
(file di server tidak diedit manual):
|
|
```bash
|
|
# lokal
|
|
git bundle create sfa-api.bundle 8a6ceec..origin/develop
|
|
scp -i mito-dev-snk.pem sfa-api.bundle ubuntu@16.79.56.41:/tmp/sfa-api.bundle
|
|
# server
|
|
cd /var/www/sfa_api_mito
|
|
sudo git fetch -q /tmp/sfa-api.bundle refs/remotes/origin/develop
|
|
sudo git merge --ff-only FETCH_HEAD
|
|
sudo git update-ref refs/remotes/origin/develop HEAD
|
|
rm /tmp/sfa-api.bundle
|
|
sudo pm2 restart sfa-api-dev --update-env
|
|
```
|
|
**Verifikasi:** `GET /registration/master-data` → 200; lookup dengan konstanta Node di server →
|
|
`lookup Dealer => [{"id":6,"name":"Dealer"}]`.
|
|
|
|
---
|
|
|
|
## Root Cause Summary
|
|
|
|
| # | Masalah | Penyebab | Fix |
|
|
|---|---------|----------|-----|
|
|
| 1 | 400 `arrayMin` attachment | Submit registrasi customer wajib ≥ 1 dokumen; payload kirim `[]` | Kirim 1 dokumen data URI base64 (opsionalisasi masih lokal, belum di-commit) |
|
|
| 2 | 500 `Role Customer belum ada` | Role id 6 `Customer` di-rename jadi `Dealer` lewat Shield; Node lookup by name | `ROLE_CUSTOMER = "Dealer"` (`19fba4d`) + migration rename idempotent (`940e492`) |
|
|
| 3 | Node server tidak bisa `git fetch` | Remote HTTPS tanpa kredensial, belum ada deploy key sfa-api | Fast-forward lewat `git bundle` + `pm2 restart` |
|
|
|
|
---
|
|
|
|
## Rekomendasi Jangka Panjang
|
|
- **Kunci role sistem** (`Dealer`, `Dealer Staff`) di UI Shield: `RolePolicy::delete/update` saat ini hanya
|
|
cek permission `delete_role` / `update_role`. Tambah guard supaya nama role sistem tidak bisa diubah/dihapus.
|
|
- ✅ **Node tidak lagi bergantung nama role** (20-10-2026, sfa-api `a7e02f8`, sfa-cms `8153d41`): Node membuat akun
|
|
registrant **tanpa role**; admin memilih role External saat Approve (dipasang berdasarkan id). Fix `19fba4d`
|
|
(`ROLE_CUSTOMER = "Dealer"`) sudah tidak dipakai. Alur: [[SFA — Self Registration#Alur Pemasangan Role (Approve)]].
|
|
- **Deploy key sfa-api di server** (pola sama dengan `sfa_cms_deploy`, SSH port 222) + job Jenkins untuk Node,
|
|
supaya deploy Node tidak manual.
|
|
- Production (5 server): deploy **CMS dulu** (`8153d41`, form Approve pilih role), baru Node (`a7e02f8`). Kalau Node
|
|
duluan, registrant baru tanpa role di-approve form lama → user APPROVED tanpa role. Migration `000003` tetap
|
|
menyamakan nama `Customer` → `Dealer`.
|
|
|
|
---
|
|
|
|
## Warning / Catatan Tambahan
|
|
- Migration `2025_10_20_000007_create_invent_on_hand_view` dan `2025_10_20_000009_fix_invent_on_hand_view_match_production`
|
|
masih **Pending** di server dev (sengaja dilewati skrip `sfa-cms deploy`, lihat [[2026-10-06_deploy-sfa-cms-dev]]).
|
|
- Setelah Error 2 beres, submit masih bisa ditolak 409 / 400 kalau `referral_empl_code` tidak valid
|
|
(request tanpa token) atau email/NPWP tidak cocok dengan master customer.
|